src/runtime.js - Issue 3141022: Using array index hash code for string-to-number conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.js

Issue 3141022: Using array index hash code for string-to-number conversion. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.js

===================================================================

--- src/runtime.js (revision 5357)

+++ src/runtime.js (working copy)

@@ -502,7 +502,10 @@

// ECMA-262, section 9.3, page 31.

function ToNumber(x) {

if (IS_NUMBER(x)) return x;

- if (IS_STRING(x)) return %StringToNumber(x);

+ if (IS_STRING(x)) {

+ return %_HasCachedArrayIndex(x) ? %_GetCachedArrayIndex(x)

+ : %StringToNumber(x);

+ }

if (IS_BOOLEAN(x)) return x ? 1 : 0;

if (IS_UNDEFINED(x)) return $NaN;

return (IS_NULL(x)) ? 0 : ToNumber(%DefaultNumber(x));

« no previous file with comments | « src/runtime.cc ('k') | src/v8natives.js » ('j') | no next file with comments »