Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: src/runtime.js

Issue 3141022: Using array index hash code for string-to-number conversion. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | src/v8natives.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 if (IS_STRING(x)) return x.length != 0; 495 if (IS_STRING(x)) return x.length != 0;
496 if (x == null) return false; 496 if (x == null) return false;
497 if (IS_NUMBER(x)) return !((x == 0) || NUMBER_IS_NAN(x)); 497 if (IS_NUMBER(x)) return !((x == 0) || NUMBER_IS_NAN(x));
498 return true; 498 return true;
499 } 499 }
500 500
501 501
502 // ECMA-262, section 9.3, page 31. 502 // ECMA-262, section 9.3, page 31.
503 function ToNumber(x) { 503 function ToNumber(x) {
504 if (IS_NUMBER(x)) return x; 504 if (IS_NUMBER(x)) return x;
505 if (IS_STRING(x)) return %StringToNumber(x); 505 if (IS_STRING(x)) {
506 return %_HasCachedArrayIndex(x) ? %_GetCachedArrayIndex(x)
507 : %StringToNumber(x);
508 }
506 if (IS_BOOLEAN(x)) return x ? 1 : 0; 509 if (IS_BOOLEAN(x)) return x ? 1 : 0;
507 if (IS_UNDEFINED(x)) return $NaN; 510 if (IS_UNDEFINED(x)) return $NaN;
508 return (IS_NULL(x)) ? 0 : ToNumber(%DefaultNumber(x)); 511 return (IS_NULL(x)) ? 0 : ToNumber(%DefaultNumber(x));
509 } 512 }
510 513
511 514
512 // ECMA-262, section 9.8, page 35. 515 // ECMA-262, section 9.8, page 35.
513 function ToString(x) { 516 function ToString(x) {
514 if (IS_STRING(x)) return x; 517 if (IS_STRING(x)) return x;
515 if (IS_NUMBER(x)) return %_NumberToString(x); 518 if (IS_NUMBER(x)) return %_NumberToString(x);
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 throw %MakeTypeError('cannot_convert_to_primitive', []); 623 throw %MakeTypeError('cannot_convert_to_primitive', []);
621 } 624 }
622 625
623 626
624 // NOTE: Setting the prototype for Array must take place as early as 627 // NOTE: Setting the prototype for Array must take place as early as
625 // possible due to code generation for array literals. When 628 // possible due to code generation for array literals. When
626 // generating code for a array literal a boilerplate array is created 629 // generating code for a array literal a boilerplate array is created
627 // that is cloned when running the code. It is essiential that the 630 // that is cloned when running the code. It is essiential that the
628 // boilerplate gets the right prototype. 631 // boilerplate gets the right prototype.
629 %FunctionSetPrototype($Array, new $Array(0)); 632 %FunctionSetPrototype($Array, new $Array(0));
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | src/v8natives.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698