Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 3141015: Ameliorate First Run Bubble race condition on XP (Closed)

Created:
10 years, 4 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Stretch first run bubble linger time out to 3 seconds to avoid getting burned by page loading issues on slow Windows boxes. This only affects the "Search from the omnibox" bubble that appears on the very first install of Chrome. This solution came after a long discussion w/jcivelli yesterday. A perfect solution to this problem would be too complex for M6, because it would involve triggering only when all first run pages have actually finished loading in the browser; this solution manages to both avoid getting stepped on by loading in all but the slowest machines -- and, if it does get stepped on, to at least actually show the bubble for 3 seconds. BUG=51704 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/views/first_run_bubble.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Miranda Callahan
10 years, 4 months ago (2010-08-13 16:48:34 UTC) #1
Jay Civelli
10 years, 4 months ago (2010-08-13 16:51:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698