Better build_image for factory install

build_image

 #!/bin/bash
 
 # Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to build a bootable keyfob-based chromeos system image from within
 # a chromiumos setup. This assumes that all needed packages have been built into
 # the given target's root with binary packages turned on. This script will
 # build the Chrome OS image using only pre-built binary packages.
@@ skipping 78 matching lines @@
 # Only now can we die on error.  shflags functions leak non-zero error codes,
 # so will die prematurely if 'set -e' is specified before now.
 set -e
 
 if [ -z "${FLAGS_board}" ] ; then
   error "--board is required."
   exit 1
 fi
 
 # Verify user didn't specify incompatible flags for dev install shim
-if [ ${FLAGS_factory_install} -eq ${FLAGS_TRUE} ] &&
-   [ ${FLAGS_dev_install} -eq ${FLAGS_TRUE} ] ; then
-  error "Incompatible flags: --factory_install and --dev_install cannot be \
+if [ "${FLAGS_factory_install}" -eq "${FLAGS_TRUE}" ] &&
+   [ "${FLAGS_dev_install}" -eq "${FLAGS_TRUE}" ] ; then
+  die "Incompatible flags: --factory_install and --dev_install cannot be \
 both set to True. Please specify one or none."
-  exit 1
 fi
 
 INSTALL_MASK=""
-if [ ${FLAGS_installmask} -eq ${FLAGS_TRUE} ] ; then
+if [ "${FLAGS_installmask}" -eq "${FLAGS_TRUE}" ] ; then
   INSTALL_MASK="${DEFAULT_INSTALL_MASK}"
 fi
 
 # Reduce the size of factory install shim.
-if [ ${FLAGS_factory_install} -eq ${FLAGS_TRUE} ] ||
-   [ ${FLAGS_dev_install} -eq ${FLAGS_TRUE} ] ; then
+if [ "${FLAGS_factory_install}" -eq "${FLAGS_TRUE}" ] ||
+   [ "${FLAGS_dev_install}" -eq "${FLAGS_TRUE}" ] ; then
   # Disable --withdev flag when --*_install is set to True. Otherwise, the
   # dev image produced will be based on install shim, rather than a pristine
   # image
-  if [ ${FLAGS_withdev} -eq ${FLAGS_TRUE} ]; then
+  if [ "${FLAGS_withdev}" -eq "${FLAGS_TRUE}" ]; then
     info "Incompatible flags: --withdev and --dev_install or --factory_install \
 cannot be both set to True. Reset --withdev to False."
     FLAGS_withdev=${FLAGS_FALSE}
   fi
 
   # TODO: Build a separated ebuild for the install shim to reduce size.
   INSTALL_MASK="${INSTALL_MASK} ${FACTORY_INSTALL_MASK}"
 
   info "Fixing the rootfs size at 300 MiB for install shim"
   FLAGS_rootfs_size=280
@@ skipping 10 matching lines @@
 
 EMERGE_BOARD_CMD="emerge-${FLAGS_board}"
 if [ "${FLAGS_fast}" -eq "${FLAGS_TRUE}" ]; then
   echo "Using alternate emerge"
   EMERGE_BOARD_CMD="${SCRIPTS_DIR}/parallel_emerge --board=${FLAGS_board}"
 fi
 
 # Determine build version.
 . "${SCRIPTS_DIR}/chromeos_version.sh"
 
+# Configure extra USE or packages for this type of build.
+EXTRA_PACKAGES=""
+EXTRA_USE=""
+if [ "${FLAGS_factory_install}" -eq "${FLAGS_TRUE}" ] ; then
+  # Factory install needs to have the kernel initrmafs enabled,
+  # and the factory installer added.
+  EXTRA_PACKAGES="chromeos-base/chromeos-factoryinstall"
+  EXTRA_USE="initramfs"
+fi
+
+# Freshen kernel with correct USE flags. This is a noop if we have
+# the right kernel prebuilt. Factory install uses USE="initramfs".
+# We don't allow building from source with the image as a target,
+# and it's not possible to store prebuilts for the same package
+# with different use flags.
+USE="${EXTRA_USE}" emerge-${FLAGS_board} \
+    -uNDvg --binpkg-respect-use=y kernel
+
 # Use canonical path since some tools (e.g. mount) do not like symlinks.
 # Append build attempt to output directory.
 IMAGE_SUBDIR="${CHROMEOS_VERSION_STRING}-a${FLAGS_build_attempt}"
 OUTPUT_DIR="${FLAGS_output_root}/${FLAGS_board}/${IMAGE_SUBDIR}"
 
 OUTSIDE_OUTPUT_DIR="../build/images/${FLAGS_board}/${IMAGE_SUBDIR}"
 
 # If we are creating a developer image, also create a pristine image with a
 # different name.
 DEVELOPER_IMAGE_NAME=
@@ skipping 269 matching lines @@
   echo "Updating base packages on ${image_name}"
 
   # Create stateful partition of the same size as the rootfs.
   trap "mount_gpt_cleanup" EXIT
 
   ${SCRIPTS_DIR}/mount_gpt_image.sh --from "${OUTPUT_DIR}" \
     --image "${image_name}" -r "${ROOT_FS_DIR}" \
     -s "${STATEFUL_FS_DIR}" -e "${ESP_FS_DIR}"
 
   # Emerge updated packages, exactly like when creating base image
-  sudo INSTALL_MASK="${INSTALL_MASK}" ${EMERGE_BOARD_CMD} \
+  sudo USE="${EXTRA_USE}" INSTALL_MASK="${INSTALL_MASK}" ${EMERGE_BOARD_CMD} \
     --root="${ROOT_FS_DIR}" --root-deps=rdeps \
-    --usepkg -uDNv chromeos ${EMERGE_JOBS}
+    --usepkg -uDNv chromeos ${EXTRA_PACKAGES} ${EMERGE_JOBS}
 
   # Clean out unused packages
   sudo INSTALL_MASK="${INSTALL_MASK}" ${EMERGE_BOARD_CMD} \
     --root="${ROOT_FS_DIR}" --root-deps=rdeps \
     --usepkg --depclean ${EMERGE_JOBS}
 
   trap - EXIT
   ${SCRIPTS_DIR}/mount_gpt_image.sh -u -r "${ROOT_FS_DIR}" \
     -s "${STATEFUL_FS_DIR}" -e "${ESP_FS_DIR}"
 }
@@ skipping 115 matching lines @@
   sudo mkdir -p "${ROOT_FS_DIR}/usr/local"
   sudo mount --bind "${DEV_IMAGE_ROOT}" "${ROOT_FS_DIR}/usr/local"
   sudo mkdir -p "${ROOT_FS_DIR}/var"
   sudo mount --bind "${STATEFUL_FS_DIR}/var" "${ROOT_FS_DIR}/var"
   sudo mkdir -p "${ROOT_FS_DIR}/dev"
 
   # We "emerge --root=${ROOT_FS_DIR} --root-deps=rdeps --usepkg" all of the
   # runtime packages for chrome os. This builds up a chrome os image from
   # binary packages with runtime dependencies only.  We use INSTALL_MASK to
   # trim the image size as much as possible.
-  sudo INSTALL_MASK="${INSTALL_MASK}" ${EMERGE_BOARD_CMD} \
+  sudo USE="${EXTRA_USE}" INSTALL_MASK="${INSTALL_MASK}" ${EMERGE_BOARD_CMD} \
     --root="${ROOT_FS_DIR}" --root-deps=rdeps \
-    --usepkg chromeos ${EMERGE_JOBS}
+    --usepkg chromeos ${EXTRA_PACKAGES} ${EMERGE_JOBS}
 
   # Perform any customizations on the root file system that are needed.
   "${SCRIPTS_DIR}/customize_rootfs" \
     --root="${ROOT_FS_DIR}" \
     --target="${ARCH}" \
     --board="${BOARD}"
 
   # Populates the root filesystem with legacy bootloader templates
   # appropriate for the platform.  The autoupdater and installer will
   # use those templates to update the legacy boot partition (12/ESP)
@@ skipping 134 matching lines @@
   echo "Developer image created as ${DEVELOPER_IMAGE_NAME}"
 fi
 
 print_time_elapsed
 
 echo "To copy to USB keyfob, OUTSIDE the chroot, do something like:"
 echo "  ./image_to_usb.sh --from=${OUTSIDE_OUTPUT_DIR} --to=/dev/sdX"
 echo "To convert to VMWare image, INSIDE the chroot, do something like:"
 echo "  ./image_to_vm.sh --from=${OUTSIDE_OUTPUT_DIR} --board=${BOARD}"
 echo "from the scripts directory where you entered the chroot."