DOMUI: Implement the 'Remove...' button on the AutoFill page.

DOMUI: Implement the 'Remove...' button on the AutoFill page.

BUG=49094
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57238

[James Hawkins, 2010-08-24 20:33:46]

dhollowa: PDM change
csilv: DOMUI changes

[csilv, 2010-08-24 20:54:50]

LGTM

http://codereview.chromium.org/3140026/diff/1/6
File chrome/browser/resources/options/autofill_options.js (right):

http://codereview.chromium.org/3140026/diff/1/6#newcode130
chrome/browser/resources/options/autofill_options.js:130: profileList =
$('profileList');
better to have this be 'var profileList'...?

http://codereview.chromium.org/3140026/diff/1/6#newcode132
chrome/browser/resources/options/autofill_options.js:132:
profileList.options[addressOffset + this.numAddresses];
this.numAddresses should always be zero here since resetAddresses_() was called
above.  not a bug of course, but just thought i'd point it out.

http://codereview.chromium.org/3140026/diff/1/6#newcode152
chrome/browser/resources/options/autofill_options.js:152: profileList =
$('profileList');
better to have this be 'var profileList'...?

[James Hawkins, 2010-08-24 21:02:05]

http://codereview.chromium.org/3140026/diff/1/6
File chrome/browser/resources/options/autofill_options.js (right):

http://codereview.chromium.org/3140026/diff/1/6#newcode130
chrome/browser/resources/options/autofill_options.js:130: profileList =
$('profileList');
On 2010/08/24 20:54:50, csilv wrote:
> better to have this be 'var profileList'...?

Done.

http://codereview.chromium.org/3140026/diff/1/6#newcode132
chrome/browser/resources/options/autofill_options.js:132:
profileList.options[addressOffset + this.numAddresses];
On 2010/08/24 20:54:50, csilv wrote:
> this.numAddresses should always be zero here since resetAddresses_() was
called
> above.  not a bug of course, but just thought i'd point it out.

Done.

http://codereview.chromium.org/3140026/diff/1/6#newcode152
chrome/browser/resources/options/autofill_options.js:152: profileList =
$('profileList');
On 2010/08/24 20:54:50, csilv wrote:
> better to have this be 'var profileList'...?

Done.

[dhollowa, 2010-08-24 21:02:38]

LGTM.