Issue 3140022: Remove wstrings from bookmarks, part 7.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3140022: Remove wstrings from bookmarks, part 7. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
brettw, Miranda Callahan

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, ncarter (slow), idana, Raghu Simha, tim (not reviewing), John Grabowski, pam+watch_chromium.org

Visibility:
Public.

Description

Remove wstrings from bookmarks, part 7. BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57000

Patch Set 1 #

Patch Set 2 : moar fixes #

Patch Set 3 : yet more fixes #

Patch Set 4 : oops! #

Total comments: 1

Patch Set 5 : it was the worst of times #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
M	app/tree_node_model.h	View	1 2 3 4	3 chunks	+2 lines, -8 lines	0 comments	Download
M	app/tree_node_model_unittest.cc	View	1 2 3	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/cookies_window_controller_unittest.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/bookmark_model_associator.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

10 years, 4 months ago (2010-08-21 16:35:22 UTC) #2

lgtmwn

http://codereview.chromium.org/3140022/diff/7001/8001
File app/tree_node_model.h (right):

http://codereview.chromium.org/3140022/diff/7001/8001#newcode1
app/tree_node_model.h:1: // Copyright (c) 2006-2008 The Chromium Authors. All
rights reserved.
"We will sell no wine before its time."

Expand Messages | Collapse Messages