Issue 3140013: Flush more often in gclient's SubprocessCallAndFilter....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3140013: Flush more often in gclient's SubprocessCallAndFilter.... (Closed)

Created:
10 years, 4 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain, M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Flush more often in gclient's SubprocessCallAndFilter. Speed up flushing of output on platforms that may not flush as often as we expect (like Windows). Wait at least 10s between flushes to avoid overloading busy readers. BUG=none TEST=gclient flushes on Windows more often, regular gclient operations continue to work as expected Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56217

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	gclient_utils.py	View		2 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chase

gcl presubmit was failing locally (stuck in subprocess's call to select.select). Posting this with -f ...

10 years, 4 months ago (2010-08-16 18:59:54 UTC) #1

lgtm

Expand Messages | Collapse Messages