Issue 3140009: [Mac] Fix aesthetic issues with themes given the new TopChrome changes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3140009: [Mac] Fix aesthetic issues with themes given the new TopChrome changes.... (Closed)

Created:
10 years, 4 months ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Fix aesthetic issues with themes given the new TopChrome changes. o Just use the provided toolbar background color as the "highlight" color in most cases and don't draw a bevel on the templated buttons. BUG=51430 TEST=see bug. make sure no jank. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55906

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -12 lines)			Patch
M	chrome/browser/browser_theme_provider.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/browser_theme_provider.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/gradient_button_cell.mm	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/styled_text_field_cell.mm	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/tab_strip_view.mm	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_view.mm	View	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages