Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 3139013: 802.1x EAP-TLS Authentication for wifi tests (Closed)

Created:
10 years, 4 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

802.1x EAP-TLS Authentication for wifi tests Added the 802.1x authentication method to the list of tests. This involved upgrading all the testbed machines to use a hostapd that had the internal radius server enabled, reconfiguring site_wlan_connect to be able to pass the right parameters to flimflamd in order to do a file-based certificate authentication, and adding both client and server routines to site_wifi. The certificate information is hard-coded in site_eap_tls.py. The actual key content is less interesting than the fact that this data is usable. Note that this test does not use the TPA to perform authentication since this requires entd to be running, and a user logged in on console, etc., etc., which is difficult to accomplish over ssh. TEST=Run test suite BUG=none

Patch Set 1 #

Patch Set 2 : Clean up the router key loop a little #

Total comments: 2

Patch Set 3 : Change eap_tls to eap-tls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -6 lines) Patch
A server/site_eap_tls.py View 1 1 chunk +168 lines, -0 lines 0 comments Download
M server/site_linux_router.py View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A server/site_tests/network_WiFiSecMat/019CheckWPA_1x_AES View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M server/site_wifitest.py View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M server/site_wlan_connect.py View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Leffler
Prefer eap-tls to eap_tls but your call. LGTM http://codereview.chromium.org/3139013/diff/2001/3002 File server/site_linux_router.py (right): http://codereview.chromium.org/3139013/diff/2001/3002#newcode258 server/site_linux_router.py:258: elif ...
10 years, 4 months ago (2010-08-12 17:21:25 UTC) #1
Paul Stewart
10 years, 4 months ago (2010-08-12 17:29:01 UTC) #2
http://codereview.chromium.org/3139013/diff/2001/3002
File server/site_linux_router.py (right):

http://codereview.chromium.org/3139013/diff/2001/3002#newcode258
server/site_linux_router.py:258: elif k == 'eap_tls':
On 2010/08/12 17:21:25, Sam Leffler wrote:
> any reason not to use "eap-tls" instead of "eap_tls"?

Done.

Powered by Google App Engine
This is Rietveld 408576698