Issue 3138013: [metrics] Fix tests after libbase roll broke them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3138013: [metrics] Fix tests after libbase roll broke them (Closed)

Created:
10 years, 4 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
petkov, anush

CC:
chromium-os-reviews_chromium.org, Luigi Semenzato, sosa

Base URL:
http://src.chromium.org/git/metrics.git

Visibility:
Public.

Description

[metrics] Fix tests after libbase roll broke them Change-Id: Ie26189e05b8aaa637614ed098d8b215c6a436216

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Makefile	View		1 chunk	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

http://codereview.chromium.org/3138013/diff/1/2 File Makefile (right): http://codereview.chromium.org/3138013/diff/1/2#newcode43 Makefile:43: DAEMON_LDFLAGS = $(LDFLAGS) $(LDCONFIG) -lrt -lbase -lpthread -lgflags -lglib-2.0 ...

10 years, 4 months ago (2010-08-12 19:45:39 UTC) #2

Chris Masone

10 years, 4 months ago (2010-08-12 19:47:51 UTC) #3

http://codereview.chromium.org/3138013/diff/1/2
File Makefile (right):

http://codereview.chromium.org/3138013/diff/1/2#newcode43
Makefile:43: DAEMON_LDFLAGS = $(LDFLAGS) $(LDCONFIG) -lrt -lbase -lpthread
-lgflags -lglib-2.0
On 2010/08/12 19:45:39, petkov wrote:
> Shouldn't glib-2.0 come from the LDCONFIG/PKG_CONFIG above?
> 
> Also, 80 chars, if really needed.
> 
> 

huh.  maybe we just needed it for the tests, yeah.

Expand Messages | Collapse Messages