Issue 3138009: Split logging_UserCrash out into two other files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3138009: Split logging_UserCrash out into two other files (Closed)

Created:
10 years, 4 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@chromiumos-git//autotest.git

Visibility:
Public.

Description

Split logging_UserCrash out into two other files This is in prep of testing kernel crash sending. What was logging_UserCrash covered general crash sending as well as collecting user space crashes. I split out parts of that file into site_crash_test and logging_CrashSender. I will add additional kernel crash report sending tests to logging_CrashSender in a subsequent CL. This also pulls back logging_UserCrash into the BVTs. BUGS=1914 TEST=Ran BVTs and individual tests

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+261 lines, -409 lines)			Patch
A	client/bin/site_crash_test.py	View	1 2	1 chunk	+244 lines, -0 lines	0 comments	Download
A +	client/site_tests/logging_UncleanShutdown/control	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	client/site_tests/logging_UncleanShutdown/logging_UncleanShutdown.py	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	client/site_tests/logging_UserCrash/logging_UserCrash.py	View	1 2	5 chunks	+6 lines, -400 lines	0 comments	Download
A +	server/site_tests/logging_UncleanShutdownServer/control	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	server/site_tests/suite_BuildVerify/control	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	server/site_tests/suite_Nightly/control	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 3138009: Split logging_UserCrash out into two other files (Closed)

Description

Patch Set 1 #

Patch Set 2 : Bug fixes #

Patch Set 3 : Clean up imports #

Messages