Issue 3137038: Minor adjustments to bookmark folder menu button placement during button move...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3137038: Minor adjustments to bookmark folder menu button placement during button move... (Closed)

Created:
10 years, 4 months ago by mrossetti

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Minor adjustments to bookmark folder menu button placement during button moves/adds/deletes. In most cases it was a simple matter of not accounting for the vertical separation between buttons. In the case of a button add I reworked the logic a bit. BUG=51730 TEST=1) Cut or delete a bookmark button at the top, middle and bottom of a bookmark folder and verify that the button placement is correct. 2) Past a bookmark button at top, middle and bottom and verify button placement and that of the buttons above the insertion. 3) Drag move a button both upward and downward, including to the very top and the very bottom, and verify proper button placement and the placement of the buttons above the button moved as well as those buttons between the 'from' location and the 'to' location. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57281

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bar_folder_controller.mm	View		4 chunks	+17 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

10 years, 4 months ago (2010-08-24 21:12:35 UTC) #2

LGTM

I especially like verbosity of test description.
Do you think a unit test is a reasonable addition here?

Expand Messages | Collapse Messages