Issue 3137037: Ensure that scanner state is correctly reset when an error is encountered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3137037: Ensure that scanner state is correctly reset when an error is encountered. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Ensure that scanner state is correctly reset when an error is encountered. Add a scope object to ensure that leaving a literal scanning prematurely will clean up after itself. Also reset the literal buffer if a scanner is reinitialized with a new source code.

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -33 lines)			Patch
M	src/scanner.h	View	3 chunks	+22 lines, -0 lines	2 comments	Download
M	src/scanner.cc	View	17 chunks	+60 lines, -33 lines	0 comments	Download
M	src/utils.h	View	2 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/3137037/diff/1/3 File src/scanner.h (right): http://codereview.chromium.org/3137037/diff/1/3#newcode280 src/scanner.h:280: private: Strange spacing going on here. Please add ...

10 years, 4 months ago (2010-08-24 12:19:32 UTC) #2

Lasse Reichstein

10 years, 4 months ago (2010-08-24 12:30:21 UTC) #3

http://codereview.chromium.org/3137037/diff/1/3
File src/scanner.h (right):

http://codereview.chromium.org/3137037/diff/1/3#newcode280
src/scanner.h:280: private:
Done.

Expand Messages | Collapse Messages