Issue 3137021: fix memory leak in flimflam dbus support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3137021: fix memory leak in flimflam dbus support (Closed)

Created:
10 years, 4 months ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
Vince Laviano

CC:
chromium-os-reviews_chromium.org, Eric Shienbrood, rochberg, sleffler+cc_chromium.org, Jason Glasgow, Nathan Williams

Base URL:
ssh://git@chromiumos-git//flimflam.git

Visibility:
Public.

Description

fix memory leak in flimflam dbus support Free service data in service_reply to avoid the memory leak of server_data. Cherry pick'd from upstream. TEST=observed with valgrind and verified by running valgrind with leak reporting BUG=5115

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gdbus/watch.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2010/08/18 17:40:56, Sam Leffler wrote:
> 

LGTM

Expand Messages | Collapse Messages