Fix numerous alignment problems, both horizontal and vertical, in drawing the...

chrome/browser/chromeos/frame/normal_browser_frame_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/frame/normal_browser_frame_view.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "app/theme_provider.h"
 #include "base/command_line.h"
@@ skipping 73 matching lines @@
 gfx::Rect NormalBrowserFrameView::GetBoundsForTabStrip(
     BaseTabStrip* tabstrip) const {
   int border_thickness = FrameBorderThickness();
   if (browser_view_->UseVerticalTabs()) {
     // BrowserViewLayout adjusts the height/width based on the status area and
     // otr icon.
     gfx::Size ps = tabstrip->GetPreferredSize();
     return gfx::Rect(border_thickness, NonClientTopBorderHeight(),
                      ps.width(), browser_view_->height());
   }
-  return gfx::Rect(border_thickness, NonClientTopBorderHeight(),
+  return gfx::Rect(border_thickness, GetHorizontalTabStripVerticalOffset(false),
                    std::max(0, width() - (2 * border_thickness)),
                    tabstrip->GetPreferredHeight());
 }
 
+int NormalBrowserFrameView::GetHorizontalTabStripVerticalOffset(
+    bool restored) const {
+  return NonClientTopBorderHeight();
+}
+
 void NormalBrowserFrameView::UpdateThrobber(bool running) {
   // No window icon.
 }
 
 gfx::Size NormalBrowserFrameView::GetMinimumSize() {
   gfx::Size min_size(browser_view_->GetMinimumSize());
   int border_thickness = FrameBorderThickness();
   min_size.Enlarge(2 * border_thickness,
                    NonClientTopBorderHeight() + border_thickness);
 
@@ skipping 140 matching lines @@
   return std::max(0, FrameBorderThickness() -
       (browser_view_->IsTabStripVisible() ? kTabstripTopShadowThickness : 0));
 }
 
 void NormalBrowserFrameView::PaintMaximizedFrameBorder(gfx::Canvas* canvas) {
   ThemeProvider* tp = GetThemeProvider();
   views::Window* window = frame_->GetWindow();
 
   // Window frame mode and color
   SkBitmap* theme_frame;
-  int y = 0;
+  // HACK: This is to properly align the frame background with the tab
+  // background.  This was added because when this code was copied from the
+  // opaque frame code, that code didn't correctly handle maximized mode theme
+  // alignment.  That bug has since been fixed in a more general but more
+  // complex way in the opaque frame.  Since this file is eventually going to
+  // die (see crbug.com/52674), I'm just leaving this here rather than replacing
+  // it with the complex fix.
+  int y = -kCustomFrameBackgroundVerticalOffset - 1;
   // Never theme app and popup windows.
   if (!browser_view_->IsBrowserTypeNormal()) {
     ResourceBundle& rb = ResourceBundle::GetSharedInstance();
     theme_frame = rb.GetBitmapNamed(ShouldPaintAsActive() ?
         IDR_FRAME : IDR_FRAME_INACTIVE);
+    y = 0;  // These are never themed.
   } else if (!browser_view_->IsOffTheRecord()) {
     theme_frame = tp->GetBitmapNamed(ShouldPaintAsActive() ?
         IDR_THEME_FRAME : IDR_THEME_FRAME_INACTIVE);
-    // TODO(oshima): gtk based CHROMEOS is using non custom frame
-    // mode which does this adjustment. This should be removed
-    // once it's fully migrated to views. -1 is due to the layout
-    // difference between views and gtk and will be removed.
-    // See http://crbug.com/28580.
-    y = -kCustomFrameBackgroundVerticalOffset - 1;
   } else {
     theme_frame = tp->GetBitmapNamed(ShouldPaintAsActive() ?
         IDR_THEME_FRAME_INCOGNITO: IDR_THEME_FRAME_INCOGNITO_INACTIVE);
-    y = -kCustomFrameBackgroundVerticalOffset - 1;
   }
-  // Draw the theme frame.
+  // Draw the theme frame.  It must be aligned with the tabstrip as if we were
+  // in restored mode.  Note that the top of the tabstrip is
+  // kTabstripTopShadowThickness px off the top of the screen.
   canvas->TileImageInt(*theme_frame, 0, y, width(), theme_frame->height());
 
   // Draw the theme frame overlay
   if (tp->HasCustomImage(IDR_THEME_FRAME_OVERLAY) &&
       browser_view_->IsBrowserTypeNormal()) {
     SkBitmap* theme_overlay = tp->GetBitmapNamed(ShouldPaintAsActive() ?
         IDR_THEME_FRAME_OVERLAY : IDR_THEME_FRAME_OVERLAY_INACTIVE);
-    canvas->DrawBitmapInt(*theme_overlay, 0, 0);
+    canvas->DrawBitmapInt(*theme_overlay, 0, y);
   }
 
   if (!browser_view_->IsToolbarVisible()) {
     // There's no toolbar to edge the frame border, so we need to draw a bottom
     // edge.  The graphic we use for this has a built in client edge, so we clip
     // it off the bottom.
     SkBitmap* top_center =
         tp->GetBitmapNamed(IDR_APP_TOP_CENTER);
     int edge_height = top_center->height() - kClientEdgeThickness;
     canvas->TileImageInt(*top_center, 0,
@@ skipping 23 matching lines @@
   int bottom_y = toolbar_bounds.y() + split_point;
   SkBitmap* toolbar_left =
       tp->GetBitmapNamed(IDR_CONTENT_TOP_LEFT_CORNER);
   int bottom_edge_height =
       std::min(toolbar_left->height(), toolbar_bounds.height()) - split_point;
 
   SkColor theme_toolbar_color =
       tp->GetColor(BrowserThemeProvider::COLOR_TOOLBAR);
   canvas->FillRectInt(theme_toolbar_color, toolbar_bounds.x(), bottom_y,
                       toolbar_bounds.width(), bottom_edge_height);
-  toolbar_bounds.Inset(-kClientEdgeThickness, 0);
 
   int strip_height = browser_view_->GetTabStripHeight();
   SkBitmap* theme_toolbar = tp->GetBitmapNamed(IDR_THEME_TOOLBAR);
 
   canvas->TileImageInt(*theme_toolbar, toolbar_bounds.x(),
-      strip_height - kFrameShadowThickness, toolbar_bounds.x(),
-      bottom_y, toolbar_bounds.width(), theme_toolbar->height());
+      strip_height - kFrameShadowThickness, toolbar_bounds.x(), bottom_y,
+      toolbar_bounds.width(), theme_toolbar->height());
 
   canvas->DrawBitmapInt(*toolbar_left, 0, 0, toolbar_left->width(), split_point,
       toolbar_bounds.x() - toolbar_left->width(), toolbar_bounds.y(),
       toolbar_left->width(), split_point, false);
   canvas->DrawBitmapInt(*toolbar_left, 0,
       toolbar_left->height() - bottom_edge_height, toolbar_left->width(),
       bottom_edge_height, toolbar_bounds.x() - toolbar_left->width(), bottom_y,
       toolbar_left->width(), bottom_edge_height, false);
 
   SkBitmap* toolbar_center =
@@ skipping 10 matching lines @@
       bottom_edge_height, toolbar_bounds.right(), bottom_y,
       toolbar_right->width(), bottom_edge_height, false);
 
   // Draw the content/toolbar separator.
   canvas->FillRectInt(ResourceBundle::toolbar_separator_color,
       toolbar_bounds.x(), toolbar_bounds.bottom() - kClientEdgeThickness,
       toolbar_bounds.width(), kClientEdgeThickness);
 }
 
 }  // namespace chromeos