Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 3136038: Enable device orientation by default. (Closed)

Created:
10 years, 4 months ago by hans
Modified:
9 years, 5 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Enable device orientation by default. Enable device orientation by default. Replace the --enable-device-orientation command-line flag with a --disable-device-orientation flag. BUG=44654 TEST=browser_tests --gtest_filter="DeviceOrientationBrowserTest.*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57684

Patch Set 1 #

Patch Set 2 : Removing the disable-switch test. #

Total comments: 1

Patch Set 3 : Rebase and address Pawel's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -74 lines) Patch
M chrome/browser/device_orientation/device_orientation_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/device_orientation/enable_switch_browsertest.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/device_orientation/enable_switch_test.html View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jorlow
You can probably just remove the test. Run it past the platform leads, but LGTM.
10 years, 4 months ago (2010-08-26 16:40:06 UTC) #1
Paweł Hajdan Jr.
Drive-by with a test comment. No need to wait for another review by me. http://codereview.chromium.org/3136038/diff/3001/4001 ...
10 years, 4 months ago (2010-08-26 16:48:28 UTC) #2
hans
10 years, 4 months ago (2010-08-26 16:49:14 UTC) #3
jorlow
10 years, 3 months ago (2010-08-27 13:46:58 UTC) #4
LGTM

lets land this so it makes M7.  Platform leads, please yell if you have any
concerns.

Powered by Google App Engine
This is Rietveld 408576698