src/ia32/virtual-frame-ia32.cc - Issue 3136032: Simplify the way constructors are called and avoid pushing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/virtual-frame-ia32.cc

Issue 3136032: Simplify the way constructors are called and avoid pushing... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/virtual-frame-ia32.cc

===================================================================

--- src/ia32/virtual-frame-ia32.cc (revision 5332)

+++ src/ia32/virtual-frame-ia32.cc (working copy)

@@ -1143,9 +1143,9 @@

// and receiver on the stack.

Handle<Code> ic(Builtins::builtin(Builtins::JSConstructCall));

// Duplicate the function before preparing the frame.

- PushElementAt(arg_count + 1);

+ PushElementAt(arg_count);

Result function = Pop();

- PrepareForCall(arg_count + 1, arg_count + 1); // Spill args and receiver.

+ PrepareForCall(arg_count + 1, arg_count + 1); // Spill function and args.

function.ToRegister(edi);

// Constructors are called with the number of arguments in register

« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »