src/ia32/builtins-ia32.cc - Issue 3136032: Simplify the way constructors are called and avoid pushing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/builtins-ia32.cc

Issue 3136032: Simplify the way constructors are called and avoid pushing... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/builtins-ia32.cc

===================================================================

--- src/ia32/builtins-ia32.cc (revision 5332)

+++ src/ia32/builtins-ia32.cc (working copy)

@@ -95,10 +95,6 @@

// edi: called object

// eax: number of arguments

__ bind(&non_function_call);

- // CALL_NON_FUNCTION expects the non-function constructor as receiver

- // (instead of the original receiver from the call site). The receiver is

- // stack element argc+1.

- __ mov(Operand(esp, eax, times_4, kPointerSize), edi);

// Set expected number of arguments to zero (not changing eax).

__ Set(ebx, Immediate(0));

__ GetBuiltinEntry(edx, Builtins::CALL_NON_FUNCTION_AS_CONSTRUCTOR);

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »