Issue 3136027: First pass at convert the SSL dialogs into InfoBubbles....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3136027: First pass at convert the SSL dialogs into InfoBubbles.... (Closed)

Created:
10 years, 4 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, finnur+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

First pass at convert the SSL dialogs into InfoBubbles. This just converts it from being a dialog to being a bubble, with no significant changes to the content. This is only active on Windows, so I'm leaving the old dialog implementation behind. Known issues: - View certificate not there yet. - Doesn't look exactly like the mocks. BUG=http://crbug.com/52916 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57158

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+331 lines, -0 lines)			Patch
M	chrome/app/resources/locale_settings.grd	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/page_info_window.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/browser/views/page_info_bubble_view.h	View	1 chunk	+58 lines, -0 lines	0 comments	Download
A	chrome/browser/views/page_info_bubble_view.cc	View	1 chunk	+253 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

I believe some Campan guy wrote this initially. He seems to have disappeared off the ...

10 years, 4 months ago (2010-08-23 18:31:40 UTC) #1

LGTM

Expand Messages | Collapse Messages