Issue 3136025: Remove obviously unneeded forward declarations from headers under src/{app,base,net}.

Issue 3136025: Remove obviously unneeded forward declarations from headers under src/{app,base,net}. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, Miranda Callahan

CC:
chromium-reviews, cbentzel+watch_chromium.org, John Grabowski, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org

Visibility:
Public.

Description

Remove obviously unneeded forward declarations from headers under src/{app,base,net}. BUG=none TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56995

Patch Set 1 #

Patch Set 2 : add missing forward decl #

Total comments: 3

Patch Set 3 : it was the best of times #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -82 lines)			Patch
M	app/l10n_util.h	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
M	app/surface/transport_dib.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	app/x11_util.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/file_version_info_mac.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	base/file_version_info_win.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	base/histogram.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/linux_util.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/base/host_resolver.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/base/sdch_filter.h	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
M	net/base/transport_security_state.h	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
M	net/disk_cache/block_files.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/disk_cache/storage_block.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/ftp/ftp_network_layer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/http/http_auth_controller.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/http/http_auth_gssapi_posix.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/http/http_auth_handler.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/http/http_auth_handler_mock.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/http/http_auth_sspi_win.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/http/http_network_layer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/http/http_network_transaction.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/http/http_proxy_client_socket_pool.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/http/http_stream_factory.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_config_service_common_unittest.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/proxy/proxy_info.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	net/proxy/proxy_resolver_js_bindings.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/proxy/proxy_resolver_v8.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	net/socket/socket_test_util.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/socket/socks_client_socket_pool.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/tools/flip_server/epoll_server.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	net/url_request/url_request_context.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/url_request/url_request_ftp_job.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

10 years, 4 months ago (2010-08-21 16:31:50 UTC) #2

lgtm w/updatification

http://codereview.chromium.org/3136025/diff/2001/3001
File app/l10n_util.h (right):

http://codereview.chromium.org/3136025/diff/2001/3001#newcode1
app/l10n_util.h:1: // Copyright (c) 2006-2008 The Chromium Authors. All rights
reserved.
Lost in the mists of time...

http://codereview.chromium.org/3136025/diff/2001/3009
File net/base/sdch_filter.h (right):

http://codereview.chromium.org/3136025/diff/2001/3009#newcode1
net/base/sdch_filter.h:1: // Copyright (c) 2006-2008 The Chromium Authors. All
rights reserved.
Like sands through the hourglass...

http://codereview.chromium.org/3136025/diff/2001/3010
File net/base/transport_security_state.h (right):

http://codereview.chromium.org/3136025/diff/2001/3010#newcode1
net/base/transport_security_state.h:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
...these are the Days of our Lives.

Expand Messages | Collapse Messages