Issue 3136024: Changed to new value we support for kernel/panic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3136024: Changed to new value we support for kernel/panic. (Closed)

Created:
10 years, 4 months ago by kdlucas

Modified:
9 years, 7 months ago

Reviewers:
hughd

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@chromiumos-git//autotest.git

Visibility:
Public.

Description

Changed to new value we support for kernel/panic.

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	client/site_tests/platform_OSLimits/platform_OSLimits.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hughd

10 years, 4 months ago (2010-08-20 23:08:46 UTC) #2

LGTM

On Fri, Aug 20, 2010 at 3:57 PM,  <kdlucas@chromium.org> wrote:
> Reviewers: hughd,
>
> Description:
> Changed to new value we support for kernel/panic.
>
> Please review this at http://codereview.chromium.org/3136024/show
>
> SVN Base: ssh://git@chromiumos-git//autotest.git
>
> Affected files:
>  M client/site_tests/platform_OSLimits/platform_OSLimits.py
>
>
> Index: client/site_tests/platform_OSLimits/platform_OSLimits.py
> diff --git a/client/site_tests/platform_OSLimits/platform_OSLimits.py
> b/client/site_tests/platform_OSLimits/platform_OSLimits.py
> index
>
4794f038afeb08ce38fafa2370e0ab5a4535128e..3f17762e8ee7ace478653a9f119c815569d9da64
> 100644
> --- a/client/site_tests/platform_OSLimits/platform_OSLimits.py
> +++ b/client/site_tests/platform_OSLimits/platform_OSLimits.py
> @@ -80,7 +80,7 @@ class platform_OSLimits(test.test):
>                   }
>
>         ref_equal = {'leases': 1,
> -                     'panic': 0,
> +                     'panic': -1,
>                      'sysrq': 1,
>                      'suid-dump': 0,
>                     }
>
>
>

Expand Messages | Collapse Messages