Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Unified Diff: chrome/browser/device_orientation/provider.h

Issue 3136008: Implement device_orientation::Provider. (Closed)
Patch Set: Patch Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/device_orientation/orientation.h ('k') | chrome/browser/device_orientation/provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/device_orientation/provider.h
diff --git a/chrome/browser/device_orientation/provider.h b/chrome/browser/device_orientation/provider.h
index aaa5106c95b290393f2dc3fbf390772337cf1256..f32b0f6b527004210c2713c2bca3f6dd233d2a60 100644
--- a/chrome/browser/device_orientation/provider.h
+++ b/chrome/browser/device_orientation/provider.h
@@ -12,7 +12,7 @@ namespace device_orientation {
class Orientation;
-class Provider : public base::RefCounted<Provider> {
+class Provider : public base::RefCountedThreadSafe<Provider> {
public:
class Observer {
public:
@@ -33,8 +33,8 @@ class Provider : public base::RefCounted<Provider> {
// injected object's reference count.
static void SetInstanceForTests(Provider* provider);
- virtual void AddObserver(Observer* observer) {}
- virtual void RemoveObserver(Observer* observer) {}
+ virtual void AddObserver(Observer* observer) = 0;
+ virtual void RemoveObserver(Observer* observer) = 0;
protected:
Provider() {}
@@ -44,7 +44,7 @@ class Provider : public base::RefCounted<Provider> {
}
private:
- friend class base::RefCounted<Provider>;
+ friend class base::RefCountedThreadSafe<Provider>;
static Provider* instance_;
DISALLOW_COPY_AND_ASSIGN(Provider);
« no previous file with comments | « chrome/browser/device_orientation/orientation.h ('k') | chrome/browser/device_orientation/provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698