Issue 3135051: Add more DBus exception trampolines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3135051: Add more DBus exception trampolines (Closed)

Created:
10 years, 4 months ago by Paul Stewart

Modified:
9 years, 7 months ago

Reviewers:
Sam Leffler

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://gitrw.chromium.org/autotest.git

Visibility:
Public.

Description

Add more DBus exception trampolines At times the "GetProperties()" call on a service dies because the underlying service has been destroyed. Catch this exception and add a quirk. Also, change all the DumpLogs/sys.exit() pairs and create a shared "ErrExit()" function. BUG=none TEST=rerun testbed Add more suspenders around wlan_connect

Patch Set 1 #

Patch Set 2 : Remove extra GetProperties call #

Patch Set 3 : Dump logs if there are quirks, too #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	M	server/site_wlan_connect.py	View	1 2	6 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

10 years, 3 months ago (2010-08-27 17:45:30 UTC) #2

LGTM (we want the test code as robust as possible so we can identify+fix all the
issues that generate quirks)

Expand Messages | Collapse Messages