Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 3135044: More cgptlib tests (Closed)

Created:
10 years, 4 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Base URL:
http://src.chromium.org/git/vboot_reference.git
Visibility:
Public.

Description

More cgptlib tests Add some extra cases to SanityCheckTest() to test both header and entries being garbled at either end of the disk. Add DuplicateUniqueGuidTest() to check that GPTs having duplicate UniqueGuids in the entries are rejected. We can only check this per-disk, of course. Made some changes to the library to enforce the UniqueGuid requirement that I just started testing for. BUG=chromium-os:4854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -1 line) Patch
M firmware/lib/cgptlib/cgptlib_internal.c View 1 chunk +4 lines, -0 lines 0 comments Download
M firmware/version.c View 1 chunk +1 line, -1 line 0 comments Download
M tests/cgptlib_test.c View 6 chunks +98 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Richardson
10 years, 4 months ago (2010-08-24 17:05:13 UTC) #1
Randall Spangler
10 years, 4 months ago (2010-08-24 22:44:42 UTC) #2
LGTM, thanks

Powered by Google App Engine
This is Rietveld 408576698