Issue 3135036: Use Environment::GetVar instead of the obscure EnvQueryStr function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3135036: Use Environment::GetVar instead of the obscure EnvQueryStr function. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Use Environment::GetVar instead of the obscure EnvQueryStr function. - Remove this obscure function since it was called only once. - Use Environment::GetVar instead. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56978

Patch Set 1 #

Patch Set 2 : fix win bot #

Patch Set 3 : another fix #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -14 lines)			Patch
	M	chrome/app/client_util.cc	View	1 2	2 chunks	+8 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages