Issue 3135024: AU: make mk_memento_images not change rootfs

Issue 3135024: AU: make mk_memento_images not change rootfs (Closed)

Created:
10 years, 4 months ago by adlr

Modified:
9 years ago

Reviewers:
Nick Sanders, Will Drewry

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

AU: make mk_memento_images not change rootfs Also, enforce use of cros_generate_update_payload to generate images. BUG=5771 TEST=Ran ./cros_generate_update_payload to make full update

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -13 lines)			Patch
	M	cros_generate_update_payload	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mk_memento_images.sh	View		2 chunks	+7 lines, -12 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

Please don't check this in. http://codereview.chromium.org/3135024/diff/1/3 File mk_memento_images.sh (right): http://codereview.chromium.org/3135024/diff/1/3#newcode18 mk_memento_images.sh:18: if [ "$CROS_GENERATE_UPDATE_PAYLOAD_CALLED" != ...

10 years, 4 months ago (2010-08-16 22:28:58 UTC) #3

adlr

Sorry, it's already in. WIll push another CL to fix it shortly. -andrew On Mon, ...

10 years, 4 months ago (2010-08-16 22:42:49 UTC) #4

adlr

10 years, 4 months ago (2010-08-16 23:07:55 UTC) #5

to wrap up this thread, i've pushed the fix.

Sorry about the break

On Mon, Aug 16, 2010 at 3:42 PM, Andrew de los Reyes <adlr@chromium.org>wrote:

> Sorry, it's already in. WIll push another CL to fix it shortly.
>
> -andrew
>
>
> On Mon, Aug 16, 2010 at 3:28 PM, <nsanders@chromium.org> wrote:
>
>> Please don't check this in.
>>
>>
>> http://codereview.chromium.org/3135024/diff/1/3
>> File mk_memento_images.sh (right):
>>
>> http://codereview.chromium.org/3135024/diff/1/3#newcode18
>> mk_memento_images.sh:18: if [ "$CROS_GENERATE_UPDATE_PAYLOAD_CALLED" !=
>> "1" ]; then
>> Please don't check this in, it will break the factory installer.
>>
>>
>> http://codereview.chromium.org/3135024/show
>>
>
>

Expand Messages | Collapse Messages