Give correct value ranges to enumeration types used as opaque types.

Give correct value ranges to enumeration types used as opaque types.

This allows to remove special handling of GCC 4.4 (disabling of Value Range Propagation) from SConstruct.

BUG=http://code.google.com/p/v8/issues/detail?id=830

Committed: http://code.google.com/p/v8/source/detail?r=5278

[Mads Ager (chromium), 2010-08-16 16:32:30]

LGTM

http://codereview.chromium.org/3135022/diff/1/3
File src/frames.h (right):

http://codereview.chromium.org/3135022/diff/1/3#newcode117
src/frames.h:117: enum Id { kIdMinValue = kMinInt, kIdMaxValue = kMaxInt, NO_ID
= 0 };
There is a mix of camel case and all caps here. Could you check what the style
guide says and make it consistent?

http://codereview.chromium.org/3135022/diff/1/4
File src/objects.h (right):

http://codereview.chromium.org/3135022/diff/1/4#newcode2768
src/objects.h:2768: kFlagsMinValue = kMinInt, kFlagsMaxValue = kMaxInt
Will this fit on one line? Otherwise, please use one line per member.

http://codereview.chromium.org/3135022/diff/1/5
File src/platform.h (right):

http://codereview.chromium.org/3135022/diff/1/5#newcode367
src/platform.h:367: kLocalStorageKeyMinValue = kMinInt, kLocalStorageKeyMaxValue
= kMaxInt
One member per line?

[tfarina, 2010-08-16 18:06:44]

http://codereview.chromium.org/3135022/diff/1/3
File src/frames.h (right):

http://codereview.chromium.org/3135022/diff/1/3#newcode117
src/frames.h:117: enum Id { kIdMinValue = kMinInt, kIdMaxValue = kMaxInt, NO_ID
= 0 };
On 2010/08/16 16:32:30, Mads Ager wrote:
> There is a mix of camel case and all caps here. Could you check what the style
> guide says and make it consistent?
There is a divergence in google/chromium style. Not sure what v8 is using
though.

The chromium coding style says:
"Though the style guide says to use kConstantNaming for enums now, we still use
MACRO_STYLE naming for enums for consistency with existing code."
http://www.chromium.org/developers/coding-style

But Google C++ style says:
Enumerators should be named either like constants or like macros: either
kEnumName or ENUM_NAME.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Enumer...