Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 3135016: Commit the change that I forgot to commit. (Closed)

Created:
10 years, 4 months ago by fes
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org
Base URL:
http://src.chromium.org/git/tpm_init.git
Visibility:
Public.

Description

Commit the change that I forgot to commit. This change should have gone into the earlier push, but I neglected to commit it. It merely sets up some local variables, which was the cause of the build failure. Change-Id: I91e39c8f0101ff8693fd4805423fbbf8fedf7a0f BUG=none TEST=build

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tpm.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fes
10 years, 4 months ago (2010-08-13 17:28:12 UTC) #1
Chris Masone
10 years, 4 months ago (2010-08-13 17:29:53 UTC) #2
LGTM

On Fri, Aug 13, 2010 at 10:28 AM, <fes@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> Commit the change that I forgot to commit.
>
> This change should have gone into the earlier push, but I neglected to
> commit
> it.  It merely sets up some local variables, which was the cause of the
> build
> failure.
>
> Change-Id: I91e39c8f0101ff8693fd4805423fbbf8fedf7a0f
>
> BUG=none
> TEST=build
>
> Please review this at http://codereview.chromium.org/3135016/show
>
> SVN Base: http://src.chromium.org/git/tpm_init.git
>
> Affected files:
>  M tpm.cc
>
>
> Index: tpm.cc
> diff --git a/tpm.cc b/tpm.cc
> index
>
b18514596f24f6d7b7ddc10d06d5667b8cb5ead1..4de12a26f52d89677a0d09597922bf81c1a38009
> 100644
> --- a/tpm.cc
> +++ b/tpm.cc
> @@ -541,13 +541,14 @@ bool Tpm::InitializeTpm() {
>   }
>
>   // Ensure the SRK is available
> +  TSS_RESULT result;
>   TSS_HKEY srk_handle;
>   TSS_UUID SRK_UUID = TSS_UUID_SRK;
> -  if ((result = Tspi_Context_LoadKeyByUUID(context_handle,
> TSS_PS_TYPE_SYSTEM,
> +  if ((result = Tspi_Context_LoadKeyByUUID(context_handle_,
> TSS_PS_TYPE_SYSTEM,
>                                            SRK_UUID, &srk_handle))) {
>     is_srk_available_ = false;
>   } else {
> -    Tspi_Context_CloseObject(context_handle, srk_handle);
> +    Tspi_Context_CloseObject(context_handle_, srk_handle);
>     is_srk_available_ = true;
>   }
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698