Update to NSS 3.12.7 and NSPR 4.8.6....

nss/mozilla/security/nss/lib/pk11wrap/pk11auth.c

 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 (the "License"); you may not use this file except in compliance with
  * the License. You may obtain a copy of the License at
  * http://www.mozilla.org/MPL/
  *
  * Software distributed under the License is distributed on an "AS IS" basis,
  * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
@@ skipping 461 matching lines @@
 }
 
 /*
  * Change an existing user password
  */
 SECStatus
 PK11_ChangePW(PK11SlotInfo *slot, const char *oldpw, const char *newpw)
 {
     CK_RV crv;
     SECStatus rv = SECFailure;
-    int newLen;
-    int oldLen;
+    int newLen = 0;
+    int oldLen = 0;
     CK_SESSION_HANDLE rwsession;
 
     /* use NULL values to trigger the protected authentication path */
-    if (slot->protectedAuthPath) {
-        if (newpw == NULL) newLen = 0;
-        if (oldpw == NULL) oldLen = 0;
-    } else {
+    if (!slot->protectedAuthPath) {
         if (newpw == NULL) newpw = "";
         if (oldpw == NULL) oldpw = "";
-        newLen = PORT_Strlen(newpw);
-        oldLen = PORT_Strlen(oldpw);
     }
-
+    if (newpw) newLen = PORT_Strlen(newpw);
+    if (oldpw) oldLen = PORT_Strlen(oldpw);
 
     /* get a rwsession */
     rwsession = PK11_GetRWSession(slot);
     if (rwsession == CK_INVALID_SESSION) {
         PORT_SetError(SEC_ERROR_BAD_DATA);
         return rv;
     }
 
     crv = PK11_GETTAB(slot)->C_SetPIN(rwsession,
                 (unsigned char *)oldpw,oldLen,(unsigned char *)newpw,newLen);
@@ skipping 276 matching lines @@
     case CKS_RO_PUBLIC_SESSION:
     default:
         break; /* fail */
     case CKS_RW_USER_FUNCTIONS:
     case CKS_RW_SO_FUNCTIONS:
     case CKS_RO_USER_FUNCTIONS:
         return PR_TRUE;
     }
     return PR_FALSE; 
 }