Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2179)

Unified Diff: base/command_line.h

Issue 3134008: CommandLine: eliminate wstring-accepting AppendLooseValue (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: utf8 Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/command_line.cc » ('j') | base/command_line.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/command_line.h
diff --git a/base/command_line.h b/base/command_line.h
index 10fbc9287c3b0ab55eae6a57c0cf9a8f69eb7765..e4ac08b2b204b50d01f0e03b11b7f759dd477add 100644
--- a/base/command_line.h
+++ b/base/command_line.h
@@ -141,8 +141,14 @@ class CommandLine {
void AppendSwitchASCII(const std::string& switch_string,
const std::string& value);
- // Append a loose value to the command line.
- void AppendLooseValue(const std::wstring& value);
+ // Append an argument to the command line.
+ // Note on quoting: the argument will be quoted properly such that it is
+ // interpreted as one argument to the target command.
+ // AppendArg is primarily for ASCII; non-ASCII input will be
+ // interpreted as UTF-8.
+ void AppendArg(const std::string& value);
+ void AppendArgPath(const FilePath& value);
+ void AppendArgNative(const StringType& value);
// Append the arguments from another command line to this one.
// If |include_program| is true, include |other|'s program as well.
« no previous file with comments | « no previous file | base/command_line.cc » ('j') | base/command_line.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698