Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 3133022: sync: take two for: "Added classes to enable session sync... (Closed)

Created:
10 years, 4 months ago by tim (not reviewing)
Modified:
9 years, 6 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, ben+cc_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

sync: take two for: Added classes to enable session sync functionality. TEST=ProfileSyncServiceSessionTest BUG=30519 Original patch by : jerrica@chromium.org Original review http://codereview.chromium.org/3168009 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2112 lines, -43 lines) Patch
M chrome/browser/browser_commands_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/browser/dom_ui/foreign_session_handler.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/foreign_session_handler.cc View 1 chunk +151 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/value_helper.h View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/value_helper.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_restore.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_types.h View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_types.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.h View 5 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.h View 4 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 5 chunks +23 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/sync/glue/session_change_processor.h View 1 chunk +75 lines, -0 lines 0 comments Download
A chrome/browser/sync/glue/session_change_processor.cc View 1 chunk +132 lines, -0 lines 0 comments Download
A chrome/browser/sync/glue/session_data_type_controller.h View 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/sync/glue/session_data_type_controller.cc View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/browser/sync/glue/session_model_associator.h View 1 chunk +201 lines, -0 lines 0 comments Download
A chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +527 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 4 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_mock.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 5 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 5 chunks +18 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 chunk +417 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 7 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/browser_with_test_window_test.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/browser_with_test_window_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tim (not reviewing)
10 years, 4 months ago (2010-08-17 23:10:24 UTC) #1
ncarter (slow)
10 years, 4 months ago (2010-08-17 23:15:48 UTC) #2
Rubber stamp.

 - nick

On Tue, Aug 17, 2010 at 4:10 PM, <tim@chromium.org> wrote:

> Reviewers: ncarter,
>
> Description:
> sync: take two for:
>
> Added classes to enable session sync functionality.
>
> TEST=ProfileSyncServiceSessionTest
> BUG=30519
> Original patch by : jerrica@chromium.org
> Original review http://codereview.chromium.org/3168009
>
> Please review this at http://codereview.chromium.org/3133022/show
>
> Affected files:
>  M chrome/browser/browser_commands_unittest.cc
>  A chrome/browser/dom_ui/foreign_session_handler.h
>  A chrome/browser/dom_ui/foreign_session_handler.cc
>  M chrome/browser/dom_ui/new_tab_ui.cc
>  A chrome/browser/dom_ui/value_helper.h
>  A chrome/browser/dom_ui/value_helper.cc
>  M chrome/browser/sessions/session_restore.h
>  M chrome/browser/sessions/session_restore.cc
>  M chrome/browser/sessions/session_types.h
>  M chrome/browser/sessions/session_types.cc
>  M chrome/browser/sessions/tab_restore_service.h
>  M chrome/browser/sync/abstract_profile_sync_service_test.h
>  M chrome/browser/sync/engine/syncapi.h
>  M chrome/browser/sync/engine/syncapi.cc
>  M chrome/browser/sync/glue/data_type_manager_impl.cc
>  A chrome/browser/sync/glue/session_change_processor.h
>  A chrome/browser/sync/glue/session_change_processor.cc
>  A chrome/browser/sync/glue/session_data_type_controller.h
>  A chrome/browser/sync/glue/session_data_type_controller.cc
>  A chrome/browser/sync/glue/session_model_associator.h
>  A chrome/browser/sync/glue/session_model_associator.cc
>  M chrome/browser/sync/profile_sync_factory.h
>  M chrome/browser/sync/profile_sync_factory_impl.h
>  M chrome/browser/sync/profile_sync_factory_impl.cc
>  M chrome/browser/sync/profile_sync_factory_impl_unittest.cc
>  M chrome/browser/sync/profile_sync_factory_mock.h
>  M chrome/browser/sync/profile_sync_service.h
>  M chrome/browser/sync/profile_sync_service.cc
>  M chrome/browser/sync/profile_sync_service_password_unittest.cc
>  A chrome/browser/sync/profile_sync_service_session_unittest.cc
>  M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
>  M chrome/browser/sync/sync_setup_flow.cc
>  M chrome/browser/sync/sync_setup_wizard_unittest.cc
>  M chrome/browser/sync/syncable/model_type.h
>  M chrome/browser/sync/syncable/model_type.cc
>  M chrome/browser/views/bookmark_bar_view_unittest.cc
>  M chrome/chrome.gyp
>  M chrome/chrome_browser.gypi
>  M chrome/chrome_tests.gypi
>  M chrome/common/chrome_switches.h
>  M chrome/common/chrome_switches.cc
>  M chrome/common/notification_type.h
>  M chrome/common/pref_names.h
>  M chrome/common/pref_names.cc
>  M chrome/test/browser_with_test_window_test.h
>  M chrome/test/browser_with_test_window_test.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698