Reduce size of function restarter frame.

Reduce size of function restarter frame.

Committed: http://code.google.com/p/v8/source/detail?r=5256

[Peter Rybin, 2010-08-11 17:51:22]

Hi Soren

I'm trying to imporve stack manipulation system. Currently the function
restarter frame takes 5 words on stack, while the function without locals takes
3 words.
Here I am reducing the size of restarter frame down to 4. I do not store the
context anymore and get it from the pointer to function instead.
However, StandardFrame::context() will return pointer to function now. I hope
it's not a problem.

Peter

Related bug:
http://code.google.com/p/v8/issues/detail?id=825

[Søren Thygesen Gjesse, 2010-08-12 11:30:48]

LGTM, but what is the motivation for this change? It only seems to have a local
effect.

http://codereview.chromium.org/3133007/diff/2001/3001
File src/ia32/debug-ia32.cc (right):

http://codereview.chromium.org/3133007/diff/2001/3001#newcode261
src/ia32/debug-ia32.cc:261: // Frame structure (conforms InternalFrame
structure):
Remove "conforms InternalFrame structure"?

[Peter Rybin, 2010-08-12 12:07:57]

On 2010/08/12 11:30:48, Søren Gjesse wrote:
> LGTM, but what is the motivation for this change? It only seems to have a
local
> effect.

Currently we restart only functions that have at least 2 local variables. Here I
am lowering this limit to 1 local variable. I think it may be useful.

[Peter Rybin, 2013-06-26 19:39:23]

https://codereview.chromium.org/3133007/diff/2001/src/ia32/debug-ia32.cc
File src/ia32/debug-ia32.cc (right):

https://codereview.chromium.org/3133007/diff/2001/src/ia32/debug-ia32.cc#newc...
src/ia32/debug-ia32.cc:261: // Frame structure (conforms InternalFrame
structure):
On 2010/08/12 11:30:48, Søren Gjesse wrote:
> Remove "conforms InternalFrame structure"?

I do hope it conforms. I need any stack analyzer (debugger and Top::PrintStack)
to work smoothly with it.

[Søren Gjesse, 2013-07-22 09:33:24]

Adding Yang as reviewer as I am not working actively on the V8 debugger at the
moment.

[Yang, 2013-07-22 09:59:20]

On 2013/07/22 09:33:24, Søren Gjesse wrote:
> Adding Yang as reviewer as I am not working actively on the V8 debugger at the
> moment.

This issue has already been closed long ago.