Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 3133007: Reduce size of function restarter frame. (Closed)

Created:
10 years, 4 months ago by Peter Rybin
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reduce size of function restarter frame. Committed: http://code.google.com/p/v8/source/detail?r=5256

Patch Set 1 #

Patch Set 2 : format #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/ia32/debug-ia32.cc View 1 3 chunks +13 lines, -13 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Peter Rybin
Hi Soren I'm trying to imporve stack manipulation system. Currently the function restarter frame takes ...
10 years, 4 months ago (2010-08-11 17:51:22 UTC) #1
Søren Thygesen Gjesse
LGTM, but what is the motivation for this change? It only seems to have a ...
10 years, 4 months ago (2010-08-12 11:30:48 UTC) #2
Peter Rybin
On 2010/08/12 11:30:48, Søren Gjesse wrote: > LGTM, but what is the motivation for this ...
10 years, 4 months ago (2010-08-12 12:07:57 UTC) #3
Peter Rybin
https://codereview.chromium.org/3133007/diff/2001/src/ia32/debug-ia32.cc File src/ia32/debug-ia32.cc (right): https://codereview.chromium.org/3133007/diff/2001/src/ia32/debug-ia32.cc#newcode261 src/ia32/debug-ia32.cc:261: // Frame structure (conforms InternalFrame structure): On 2010/08/12 11:30:48, ...
7 years, 6 months ago (2013-06-26 19:39:23 UTC) #4
Søren Gjesse
Adding Yang as reviewer as I am not working actively on the V8 debugger at ...
7 years, 5 months ago (2013-07-22 09:33:24 UTC) #5
Yang
7 years, 5 months ago (2013-07-22 09:59:20 UTC) #6
Message was sent while issue was closed.
On 2013/07/22 09:33:24, Søren Gjesse wrote:
> Adding Yang as reviewer as I am not working actively on the V8 debugger at the
> moment.

This issue has already been closed long ago.

Powered by Google App Engine
This is Rietveld 408576698