Issue 4448: Hide the address bar for popups in ChromeOS

BUG=chromium-os:4448
- Hide the address bar for popups in ChromeOS (http://code.google.com/p/chromium-os/issues/detail?id=4448)

Moved PopupNonClientFrameView to its own file and moved FrameView initialization logic to BrowserFrameChromeos::Init.
TEST=See issue. Additionally, ensure that non-chromeos Chrome popup window behavior is unaffected, and that the address bar is still visible for popup windows not generated by apps (e.g popped out google chat windows), on chromeos and non-chromeos.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56370

[stevenjb, 2010-08-09 22:37:50]

This is a smaller CL than it appears; I had to move PopupNonClientFrameView to
its own source file so that it could be accessed by BrowserFrameChromeos.

http://codereview.chromium.org/3133001/diff/1/3
File chrome/browser/chromeos/frame/browser_view.cc (right):

http://codereview.chromium.org/3133001/diff/1/3#newcode450
chrome/browser/chromeos/frame/browser_view.cc:450: (browser->type() ==
Browser::TYPE_APP_PANEL))
Note: this actually fixes a regression where any window of TYPE_APP that went
through this logic would become a panel (not just APP_PANEL).

http://codereview.chromium.org/3133001/diff/1/4
File chrome/browser/views/frame/browser_frame_gtk.cc (right):

http://codereview.chromium.org/3133001/diff/1/4#newcode15
chrome/browser/views/frame/browser_frame_gtk.cc:15: #include
"chrome/browser/views/frame/popup_non_client_frame_view.h"
Code moved from here to popup_non_client_frame_view.cc (no code changes).

[DaveMoore, 2010-08-13 12:17:58]

LGTM

[oshima, 2010-08-16 19:58:03]

lgtm

http://codereview.chromium.org/3133001/diff/1/5
File chrome/browser/views/frame/popup_non_client_frame_view.cc (right):

http://codereview.chromium.org/3133001/diff/1/5#newcode36
chrome/browser/views/frame/popup_non_client_frame_view.cc:36: gfx::Path*
window_mask) {
indent

http://codereview.chromium.org/3133001/diff/1/6
File chrome/browser/views/frame/popup_non_client_frame_view.h (right):

http://codereview.chromium.org/3133001/diff/1/6#newcode1
chrome/browser/views/frame/popup_non_client_frame_view.h:1: // Copyright (c)
2009 The Chromium Authors. All rights reserved.
2010

[Peter Kasting, 2010-08-16 20:16:25]

Hey guys, just a drive-by.  This only hides the address bar for panels, not for
all popups, right?  That's how I read the browser_frame modifications, but if it
applies to all popups, that'd be a security problem.

[stevenjb, 2010-08-16 21:00:41]

On 2010/08/16 20:16:25, Peter Kasting wrote:
> Hey guys, just a drive-by.  This only hides the address bar for panels, not
for
> all popups, right?  That's how I read the browser_frame modifications, but if
it
> applies to all popups, that'd be a security problem.
That's correct. There is separate logic for panels that determines when to show
the address bar. Currently that logic only hides the address bar if the panel is
an app or was created by an app (i.e. it was created by something installed by
the user, so hiding the address bar is OK). This CL merely ensures that all
popup windows are of the correct type, allowing the existing logic to work.

All that being said, it's a good concern and I will add a testing note.