Issue 3132046: Add sparse array handling to Array.protoype.indexOf/lastIndexOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3132046: Add sparse array handling to Array.protoype.indexOf/lastIndexOf. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Add sparse array handling to Array.protoype.indexOf/lastIndexOf.

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -25 lines)			Patch
M	src/array.js	View	1	2 chunks	+57 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/mjsunit/array-indexing.js	View		1 chunk	+98 lines, -17 lines	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (chromium)

Please add regression tests for this. When that is done this look good to me.

10 years, 4 months ago (2010-08-26 07:46:13 UTC) #2

Lasse Reichstein

10 years, 4 months ago (2010-08-26 08:54:49 UTC) #3

Good call. There was a bug not hit by the current tests.