Issue 3132030: dom-ui options: Setup proxy settings UI accordingly if an Extension is managi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3132030: dom-ui options: Setup proxy settings UI accordingly if an Extension is managi... (Closed)

Created:
10 years, 4 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
dhg, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

dom-ui options: Setup proxy settings UI accordingly if an Extension is managing proxies. BUG=51376 TEST=Verify proxy settings UI matches proposal when proxy settings are managed by an extension. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56940

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -12 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/advanced_options_handler.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/advanced_options_handler.cc	View	3 chunks	+26 lines, -6 lines	2 comments	Download
M	chrome/browser/resources/options/advanced_options.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/advanced_options.js	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

+jhawkins, +dhg for review. (I'm currently battling the trybots... i'll get them green eventually.)

10 years, 4 months ago (2010-08-20 18:48:59 UTC) #1

James Hawkins

LGTM http://codereview.chromium.org/3132030/diff/1/3 File chrome/browser/dom_ui/advanced_options_handler.cc (right): http://codereview.chromium.org/3132030/diff/1/3#newcode279 chrome/browser/dom_ui/advanced_options_handler.cc:279: CHECK(proxy_server); If you really want to check here, ...

10 years, 4 months ago (2010-08-20 19:51:41 UTC) #2

csilv

10 years, 4 months ago (2010-08-20 20:21:42 UTC) #3

http://codereview.chromium.org/3132030/diff/1/3
File chrome/browser/dom_ui/advanced_options_handler.cc (right):

http://codereview.chromium.org/3132030/diff/1/3#newcode279
chrome/browser/dom_ui/advanced_options_handler.cc:279: CHECK(proxy_server);
On 2010/08/20 19:51:41, James Hawkins wrote:
> If you really want to check here, this should be a DCHECK. CHECKs should only
be
> used to track down crashes in the wild.

Done.

Expand Messages | Collapse Messages