Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 3132017: GLES demos on PPAPI. (Closed)

Created:
10 years, 4 months ago by neb
Modified:
9 years, 7 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Made GLES demos work on PPAPI. BUG=none TEST=they work on Windows and Linux.

Patch Set 1 #

Patch Set 2 : Done correctly. #

Patch Set 3 : Sync. #

Patch Set 4 : Fix src being added to none targets. #

Patch Set 5 : DEPS and test_shell fixes. #

Patch Set 6 : Changed the approach and implemented a GLES2 library for PPAPI. #

Patch Set 7 : Added DEPS. #

Patch Set 8 : Comment out functions not yet in PPB_OpenGLES. #

Patch Set 9 : Alright, this should work everywhere now. #

Patch Set 10 : fix typo. #

Patch Set 11 : Moved the code-generating script into a different CL. #

Total comments: 4

Patch Set 12 : Fix context lost. #

Patch Set 13 : Pick up latest changes. #

Patch Set 14 : Removed DEPS, they are already up to date. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -7 lines) Patch
M gpu/demos/demos.gyp View 1 2 3 4 5 6 7 8 9 16 chunks +162 lines, -14 lines 0 comments Download
A gpu/demos/framework/DEPS View 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A gpu/demos/framework/pepper.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +109 lines, -0 lines 0 comments Download
A + gpu/demos/gles2_book/demo_hello_triangle.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/demos/gles2_book/demo_mip_map_2d.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/demos/gles2_book/demo_simple_texture_2d.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/demos/gles2_book/demo_simple_texture_cubemap.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/demos/gles2_book/demo_simple_vertex_shader.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/demos/gles2_book/demo_stencil_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/demos/gles2_book/demo_texture_wrap.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A gpu/demos/run_demo_ppapi.sh View 1 2 3 4 5 6 7 8 9 10 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
neb
I'm about ready to check these in - can you take a look?
10 years, 3 months ago (2010-08-30 22:30:41 UTC) #1
neb
I'm about ready to check these in - can you take a look?
10 years, 3 months ago (2010-08-30 22:30:42 UTC) #2
apatrick_chromium
Looks like the patch didn't take on the trybots. http://codereview.chromium.org/3132017/diff/30001/31004 File gpu/demos/framework/pepper.cc (right): http://codereview.chromium.org/3132017/diff/30001/31004#newcode50 gpu/demos/framework/pepper.cc:50: ...
10 years, 3 months ago (2010-08-30 22:41:53 UTC) #3
neb
Will wait for the build bots to okay it. http://codereview.chromium.org/3132017/diff/30001/31004 File gpu/demos/framework/pepper.cc (right): http://codereview.chromium.org/3132017/diff/30001/31004#newcode50 gpu/demos/framework/pepper.cc:50: ...
10 years, 3 months ago (2010-08-30 22:53:26 UTC) #4
apatrick_chromium
10 years, 3 months ago (2010-08-30 23:15:11 UTC) #5
LGTM when bots are green.

Powered by Google App Engine
This is Rietveld 408576698