Issue 3131022: AU: Update status to DOWNLOADING only after receiving some bytes from server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3131022: AU: Update status to DOWNLOADING only after receiving some bytes from server. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://src.chromium.org/git/update_engine.git

Visibility:
Public.

Description

AU: Update status to DOWNLOADING only after receiving some bytes from server. This ensures that users don't see an update download notification until after a download has successfully started. Also, added some DownloadActionDelegate unit tests. BUG=5822 TEST=unit tests, gmerged to device, made sure updates happened and notifications received Change-Id: I96912dcd98a53e9bd7eecc63dab704f959a06441

Patch Set 1 #

Patch Set 2 : fix wording #

Total comments: 4

Patch Set 3 : review feedback #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -18 lines)			Patch
M	download_action.h	View		2 chunks	+11 lines, -6 lines	0 comments	Download
M	download_action.cc	View	1 2	3 chunks	+9 lines, -0 lines	0 comments	Download
M	download_action_unittest.cc	View		9 chunks	+49 lines, -8 lines	0 comments	Download
M	update_attempter.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	update_attempter.cc	View	1	3 chunks	+12 lines, -2 lines	0 comments	Download
M	update_engine_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ nits http://codereview.chromium.org/3131022/diff/2001/8 File download_action.cc (right): http://codereview.chromium.org/3131022/diff/2001/8#newcode89 download_action.cc:89: delegate_->SetDownloadStatus(false); // active change comment? http://codereview.chromium.org/3131022/diff/2001/8#newcode126 ...

10 years, 4 months ago (2010-08-19 02:13:45 UTC) #2

petkov

10 years, 4 months ago (2010-08-19 16:35:41 UTC) #3

Pushing...

http://codereview.chromium.org/3131022/diff/2001/8
File download_action.cc (right):

http://codereview.chromium.org/3131022/diff/2001/8#newcode89
download_action.cc:89: delegate_->SetDownloadStatus(false);  // active
On 2010/08/19 02:13:45, adlr wrote:
> change comment?

Done.

http://codereview.chromium.org/3131022/diff/2001/8#newcode126
download_action.cc:126: delegate_->SetDownloadStatus(false);  // active
On 2010/08/19 02:13:45, adlr wrote:
> same

Done.

Expand Messages | Collapse Messages