Issue 3131021: Get the same margin on all sides of the notification....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3131021: Get the same margin on all sides of the notification.... (Closed)

Created:
10 years, 4 months ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Get the same margin on all sides of the notification. BUG=52545 TEST=create text notifications of various sizes, watch for a clipped bottom margin. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56598

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -6 lines)			Patch
M	chrome/browser/resources/notification_1line.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/notification_2line.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/notification_icon.html	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

John Gregg

On 2010/08/18 20:16:10, John Gregg wrote: > screenshot: http://www.corp.google.com/~johnnyg/3131021-new.png

10 years, 4 months ago (2010-08-18 20:17:28 UTC) #2

John Gregg

screenshot with icon: http://www.corp.google.com/~johnnyg/3131021-new-icon.png

10 years, 4 months ago (2010-08-18 20:19:10 UTC) #3

LGTM