Issue 3130045: Don't offer to translate the bookmark manager page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3130045: Don't offer to translate the bookmark manager page. (Closed)

Created:
10 years, 4 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy, arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Don't offer to translate the bookmark manager page. BUG=52765 TEST=Bookmark sites in a language different than the language Chrome is configured in (you should have few of them, with titles long enough, so there are more than 100 characters in that language). Go to the bookmark manager, no translate infobar should be shown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57208

Patch Set 1 #

Patch Set 2 : Synced #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/resources/bookmark_manager/main.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

Glen, Could you review this short CL, I did not realize arv was in vacation. ...

10 years, 4 months ago (2010-08-23 23:18:50 UTC) #2

LGTM

Expand Messages | Collapse Messages