Added browser test for the OOBE update screen....

Added browser test for the OOBE update screen.

BUG=chromium-os:2265
TEST=Make and run out/Debug/browser_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57053

[Dmitry Polukhin, 2010-08-23 06:30:32]

http://codereview.chromium.org/3130044/diff/1/3
File chrome/browser/chromeos/login/update_screen.h (right):

http://codereview.chromium.org/3130044/diff/1/3#newcode67
chrome/browser/chromeos/login/update_screen.h:67: bool is_testing_;
It's bad to have test mode. As far as I can see this variable only to use to
eliminate minimal update time. It's much better to make this functionality
non-test i.e. just being able to set minimal_update_time from outside of the
class.

[dr, 2010-08-23 10:40:23]

http://codereview.chromium.org/3130044/diff/1/3
File chrome/browser/chromeos/login/update_screen.h (right):

http://codereview.chromium.org/3130044/diff/1/3#newcode67
chrome/browser/chromeos/login/update_screen.h:67: bool is_testing_;
On 2010/08/23 06:30:33, Dmitry Polukhin wrote:
> It's bad to have test mode. As far as I can see this variable only to use to
> eliminate minimal update time. It's much better to make this functionality
> non-test i.e. just being able to set minimal_update_time from outside of the
> class.

Done.

[Dmitry Polukhin, 2010-08-23 10:46:48]

http://codereview.chromium.org/3130044/diff/3002/9001
File chrome/browser/chromeos/login/update_screen.cc (right):

http://codereview.chromium.org/3130044/diff/3002/9001#newcode35
chrome/browser/chromeos/login/update_screen.cc:35: minimal_update_time_(0),
It looks like you need to use kMinimalUpdateTimeSec/kWaitForRebootTimeSec as
default values. Isn't it? Or you forgot to add some files in code review.

[dr, 2010-08-23 11:19:44]

http://codereview.chromium.org/3130044/diff/3002/9001
File chrome/browser/chromeos/login/update_screen.cc (right):

http://codereview.chromium.org/3130044/diff/3002/9001#newcode35
chrome/browser/chromeos/login/update_screen.cc:35: minimal_update_time_(0),
Yep, I forgot to add wizard_controller.cc to the CL.

On 2010/08/23 10:46:48, Dmitry Polukhin wrote:
> It looks like you need to use kMinimalUpdateTimeSec/kWaitForRebootTimeSec as
> default values. Isn't it? Or you forgot to add some files in code review.

[Dmitry Polukhin, 2010-08-23 11:27:40]

LGTM