Issue 3130040: Fix LoadKernel() failing to update GPT flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3130040: Fix LoadKernel() failing to update GPT flags. (Closed)

Created:
10 years, 4 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
gauravsh, Bill Richardson

CC:
chromium-os-reviews_chromium.org, Randall Spangler, Luigi Semenzato, Bill Richardson

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Description

Fix LoadKernel() failing to update GPT flags. BUG=5654 TEST=manual Case 1: Trying a new kernel which works sudo cgpt add -P10 -T10 -S0 -i4 /dev/sda Then reboot and sudo cgpt show /dev/sda See that tries is now 9 for /dev/sda4 (since the current ChromeOS doesn't set the successful bit) Case 2: Trying a new kernel which is bad sudo dd if=/dev/zero of=/dev/sda4 count=1 conv=notrunc Then reboot and sudo cgpt show /dev/sda4 See that success=prio=tries=0 for /dev/sda4.

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -26 lines)			Patch
	M	firmware/lib/vboot_kernel.c	View		13 chunks	+35 lines, -25 lines	2 comments	Download
	M	firmware/version.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

http://codereview.chromium.org/3130040/diff/1/2 File firmware/lib/vboot_kernel.c (right): http://codereview.chromium.org/3130040/diff/1/2#newcode290 firmware/lib/vboot_kernel.c:290: goto bad_kernel; Heh, note that we'd previously missed freeing ...

10 years, 4 months ago (2010-08-20 21:20:46 UTC) #2

gauravsh

10 years, 4 months ago (2010-08-20 21:29:01 UTC) #3

lgtm

http://codereview.chromium.org/3130040/diff/1/2
File firmware/lib/vboot_kernel.c (right):

http://codereview.chromium.org/3130040/diff/1/2#newcode378
firmware/lib/vboot_kernel.c:378: if (NULL != data_key)
this null check is not needed. All the *Free() functions follow the free()
semantics. Null pointer input does nothing.

Expand Messages | Collapse Messages