Issue 3130037: Sbox IPC fix...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3130037: Sbox IPC fix... (Closed)

Created:
10 years, 4 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else), Chris Evans

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sbox IPC fix Second take, I had off-by-one bad check in line 164 for more info see review 3142022 BUG=52682 TEST=included Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56938

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -40 lines)			Patch
M	sandbox/src/crosscall_params.h	View	2 chunks	+31 lines, -20 lines	0 comments	Download
M	sandbox/src/crosscall_server.cc	View	5 chunks	+30 lines, -20 lines	0 comments	Download
M	sandbox/src/ipc_unittest.cc	View	1 chunk	+18 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

Please see my reply to cevans comments in the old review.

10 years, 4 months ago (2010-08-20 04:03:02 UTC) #1

rvargas (doing something else)

10 years, 4 months ago (2010-08-20 17:52:33 UTC) #3

LGTM.

It is a nice practice to upload a version of the patch right after
revert/re-merge so that we can see only what changed from the commited code.

http://codereview.chromium.org/3130037/diff/1/4
File sandbox/src/ipc_unittest.cc (right):

http://codereview.chromium.org/3130037/diff/1/4#newcode345
sandbox/src/ipc_unittest.cc:345: // The correct_size is 8 bytes aligned.
It would be nice to have a test here that was able to detect the failure with
the previous patch... that may be a follow up cl.

Expand Messages | Collapse Messages