Issue 313003: Support empty statements in the fast compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313003: Support empty statements in the fast compiler. (Closed)

Created:
11 years, 2 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Support empty statements in the fast compiler. Committed: http://code.google.com/p/v8/source/detail?r=3102

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/compiler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/fast-codegen.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/313003/diff/1/2 File src/compiler.cc (right): http://codereview.chromium.org/313003/diff/1/2#newcode528 Line 528: void CodeGenSelector::VisitEmptyStatement(EmptyStatement* stmt) {} Maybe a comment ...

11 years, 2 months ago (2009-10-21 11:50:01 UTC) #2

fschneider

11 years, 2 months ago (2009-10-21 11:55:31 UTC) #3

http://codereview.chromium.org/313003/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/313003/diff/1/2#newcode528
Line 528: void CodeGenSelector::VisitEmptyStatement(EmptyStatement* stmt) {}
On 2009/10/21 11:50:01, Kevin Millikin wrote:
> Maybe a comment in the function body saying // Empty statements are supported.
> or something?

Done.

Expand Messages | Collapse Messages

Issue 313003: Support empty statements in the fast compiler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages