Issue 3130029: Lands http://codereview.chromium.org/3153008 for bryeung:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3130029: Lands http://codereview.chromium.org/3153008 for bryeung: (Closed)

Created:
10 years, 4 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Visibility:
Public.

Description

Lands http://codereview.chromium.org/3153008 for bryeung: Synthetic KeyEvent delivery, part I. This delivers synthetic key events to the views hierarchy. This currently does nothing, as nothing is listening for the event in TOUCH_UI (or elsewhere). That part will come later. BUG=none TEST=unit test for key identifier conversion + manual for extension api Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56886

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Synced with latest #

Patch Set 4 : Merge #

Patch Set 5 : YAM #

Patch Set 6 : YAM #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+674 lines, -0 lines)			Patch
M	base/base.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/base.gypi	View	1 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
A	base/keyboard_code_conversion.h	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	base/keyboard_code_conversion.cc	View		1 chunk	+296 lines, -0 lines	0 comments	Download
A	base/keyboard_code_conversion_unittest.cc	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	1 2 3 4 5	3 chunks	+9 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_input_api.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_input_api.cc	View		1 chunk	+120 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_input_apitest.cc	View	1 2 3 4	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1 2 3 4	1 chunk	+55 lines, -0 lines	0 comments	Download
M	chrome/renderer/resources/renderer_extension_bindings.js	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/input/manifest.json	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/input/test.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/input/test.js	View	3 4 5	1 chunk	+51 lines, -0 lines	0 comments	Download