Issue 3130007: Add revinfo --actual to fetch the actual revisions,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3130007: Add revinfo --actual to fetch the actual revisions, (Closed)

Created:
10 years, 4 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Add revinfo --actual to fetch the actual revisions, gclient revinfo alone will now not return the actual checked out revisions but simply what's in the .gclient&DEPS. BUG=none TEST=add a --snapshot test to make sure it is not broken Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55760

Patch Set 1 #

Total comments: 1

Patch Set 2 : address nit #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -6 lines)			Patch
	M	gclient.py	View	1	2 chunks	+15 lines, -6 lines	0 comments	Download
	M	tests/gclient_smoketest.py	View		3 chunks	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

10 years, 4 months ago (2010-08-11 18:41:10 UTC) #2

LGTM

http://codereview.chromium.org/3130007/diff/1/2
File gclient.py (right):

http://codereview.chromium.org/3130007/diff/1/2#newcode805
gclient.py:805: if not x is keys[-1]:
I think the style guide prefers: if x is not keys[-1]:

Expand Messages | Collapse Messages