Issue 3127030: AutoFill address profile not seen in dropdown for name and address field on dell.com

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3127030: AutoFill address profile not seen in dropdown for name and address field on dell.com (Closed)

Created:
10 years, 4 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, ben+cc_chromium.org, dhollowa, Paweł Hajdan Jr.

Visibility:
Public.

Description

AutoFill address profile not seen in dropdown for name and address field on dell.com Modifies AutoFill heuristics to match middle initial at end of string instead of strict match of whole string. Also, adds form_field_unittest.cc with specific unit tests for pattern matching. BUG=45123 TEST=FormFieldTest.Match, NameFieldTest.MiddleInitialAtEnd Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57246

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing nit. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -7 lines)			Patch
A	chrome/browser/autofill/form_field_unittest.cc	View		1 chunk	+75 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/form_structure.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/autofill/name_field.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/autofill/name_field_unittest.cc	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

10 years, 4 months ago (2010-08-24 18:43:05 UTC) #2

LGTM

http://codereview.chromium.org/3127030/diff/1/5
File chrome/browser/autofill/name_field_unittest.cc (right):

http://codereview.chromium.org/3127030/diff/1/5#newcode324
chrome/browser/autofill/name_field_unittest.cc:324: // This case from the
dell.com checkout page.  The middle initial "mi" string
nit: is from

Expand Messages | Collapse Messages