Issue 3127024: Don't run PredictorTest.MassiveConcurrentLookupTest under Valgrind on Mac...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3127024: Don't run PredictorTest.MassiveConcurrentLookupTest under Valgrind on Mac... (Closed)

Created:
10 years, 4 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, stuartmorgan+watch_chromium.org, Alexander Potapenko, Timur Iskhodzhanov, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't run PredictorTest.MassiveConcurrentLookupTest under Valgrind on Mac BUG=52844 TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56855

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/test/data/valgrind/unit_tests.gtest_mac.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-20 14:33:05 UTC) #2

LGTM

On Fri, Aug 20, 2010 at 6:03 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Don't run PredictorTest.MassiveConcurrentLookupTest under Valgrind on Mac
> BUG=52844
> TBR=glider
>
> Please review this at http://codereview.chromium.org/3127024/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/test/data/valgrind/unit_tests.gtest_mac.txt
>
>
> Index: chrome/test/data/valgrind/unit_tests.gtest_mac.txt
> ===================================================================
> --- chrome/test/data/valgrind/unit_tests.gtest_mac.txt  (revision 55210)
> +++ chrome/test/data/valgrind/unit_tests.gtest_mac.txt  (working copy)
> @@ -34,3 +34,5 @@
>  RenderViewTest.Print*
>  # See http://crbug.com/30397.
>  TabStripControllerTest.AddRemoveTabs
> +# See http://crbug.com/52844
> +PredictorTest.MassiveConcurrentLookupTest
>
>
>

Expand Messages | Collapse Messages