Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3127017: Revert 56423 - Added classes to enable session sync functionality.... (Closed)

Created:
10 years, 4 months ago by tim (not reviewing)
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, ben+cc_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Revert 56423 - Added classes to enable session sync functionality. TEST=ProfileSyncServiceSessionTest BUG=30519 Original patch by jerrica@chromium.org Original review: http://codereview.chromium.org/3168009 Review URL: http://codereview.chromium.org/3184004 TBR=tim@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2112 lines) Patch
M chrome/browser/browser_commands_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/dom_ui/foreign_session_handler.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/dom_ui/foreign_session_handler.cc View 1 chunk +0 lines, -151 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/dom_ui/value_helper.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/dom_ui/value_helper.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/sessions/session_restore.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +0 lines, -37 lines 0 comments Download
M chrome/browser/sessions/session_types.h View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/sessions/session_types.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.h View 5 chunks +8 lines, -20 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.h View 4 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 5 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/sync/glue/session_change_processor.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/sync/glue/session_change_processor.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/sync/glue/session_data_type_controller.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/sync/glue/session_data_type_controller.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/sync/glue/session_model_associator.h View 1 chunk +0 lines, -201 lines 0 comments Download
D chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +0 lines, -527 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_mock.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 5 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 5 chunks +4 lines, -18 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 chunk +0 lines, -417 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 7 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/browser_with_test_window_test.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/browser_with_test_window_test.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tim (not reviewing)
10 years, 4 months ago (2010-08-17 21:30:08 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698