Issue 3127016: Make instance_size immediately useful for all fixed size objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3127016: Make instance_size immediately useful for all fixed size objects. (Closed)

Created:
10 years, 4 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Make instance_size immediately useful for all fixed size objects. For variable sized objects this field doesn't really make any sense so by putting a special value there we can improve SizeFromMap(). Committed: http://code.google.com/p/v8/source/detail?r=5301

Patch Set 1 #

Patch Set 2 : Review fixes #

Patch Set 3 : Review fixes #

Patch Set 4 : Comment fix. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -62 lines)			Patch
M	src/heap.cc	View	1	5 chunks	+10 lines, -10 lines	0 comments	Download
M	src/objects.h	View	1 2	6 chunks	+11 lines, -9 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+0 lines, -32 lines	0 comments	Download
M	src/objects-debug.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1 2 3	1 chunk	+15 lines, -7 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

o Renamed kVariableSize to kVariableSizeSentinel. o Added more comments. o Completely removed SlowSizeFromMap. Please take ...

10 years, 4 months ago (2010-08-18 11:31:54 UTC) #2

LGTM

Expand Messages | Collapse Messages