RSAVerify() - fail on malloc() failure.

firmware/lib/cryptolib/rsa.c

 /* Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* Implementation of RSA signature verification which uses a pre-processed
  * key for computation. The code extends Android's RSA verification code to
  * support multiple RSA key lengths and hash digest algorithms.
  */
 
@@ skipping 132 matching lines @@
     VBDEBUG(("Invalid signature type!\n"));
     return 0;
   }
 
   if (key->len != siglen_map[sig_type] / sizeof(uint32_t)) {
     VBDEBUG(("Wrong key passed in!\n"));
     return 0;
   }
 
   buf = (uint8_t*) Malloc(sig_len);
+  if (!buf)
+    return 0;
   Memcpy(buf, sig, sig_len);
 
   modpowF4(key, buf);
 
   /* Determine padding to use depending on the signature type. */
   padding = padding_map[sig_type];
 
   /* Check pkcs1.5 padding bytes. */
   for (i = 0; i < padding_size_map[sig_type]; ++i) {
     if (buf[i] != padding[i]) {
 #ifndef NDEBUG
-/* TODO(gauravsh): Replace with a macro call for logging. */
       VBDEBUG(("Padding: Expecting = %02x Got = %02x\n", padding[i], buf[i]));
 #endif
       success = 0;
     }
   }
 
   /* Check if digest matches. */
   for (; i < (int)sig_len; ++i) {
     if (buf[i] != *hash++) {
 #ifndef NDEBUG
-/* TODO(gauravsh): Replace with a macro call for logging. */
       VBDEBUG(("Digest: Expecting = %02x Got = %02x\n", padding[i], buf[i]));
 #endif
       success = 0;
     }
   }
 
   Free(buf);
 
   return success;
 }